Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Updatesite issue with the Espressif-IDE 2.10.0 #824

Merged
merged 3 commits into from
Sep 26, 2023
Merged

fix:Updatesite issue with the Espressif-IDE 2.10.0 #824

merged 3 commits into from
Sep 26, 2023

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Sep 22, 2023 •
edited by coderabbitai bot
Loading

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Refactor: Updated dependencies in the terminal connector serial bundle. Removed dependency on org.slf4j.api and added a new dependency on org.eclipse.ui.console. This change enhances the integration with Eclipse's console view, improving the user experience when interacting with the terminal.

@coderabbitai
Copy link

coderabbitai bot commented Sep 22, 2023 •
edited
Loading

Walkthrough

The change primarily involves a modification in the bundle dependencies of the com.espressif.idf.terminal.connector.serial project. The org.slf4j.api bundle has been removed, and the org.eclipse.ui.console bundle has been added.

Changes

File Summary
.../connector.serial/META-INF/MANIFEST.MF Removed org.slf4j.api bundle and added org.eclipse.ui.console bundle

🐇🎉

"In the land of code, where the shadows lie,
A bundle was removed, with a console's sigh.
But fear not dear coder, for it's not the end,
A new one was added, as a helpful friend.
So here's to changes, big and small,
May your code be strong, and never fall!" 🥕🎈

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

@kolipakakondal kolipakakondal changed the title Updatesitefix fix:Updatesite issue with the eclipse 2023-03 and lower Sep 22, 2023
coderabbitai[bot]
coderabbitai bot reviewed Sep 22, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 086a97c and 462d93e.
Files ignored due to filter (1)
  • releng/com.espressif.idf.update/category.xml
Files selected for processing (1)
  • bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1 hunks)
Files skipped from review due to trivial changes (1)
  • bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF

@kolipakakondal kolipakakondal added this to the 2.11.1 milestone Sep 22, 2023
@kolipakakondal
Copy link
Collaborator Author

kolipakakondal commented Sep 22, 2023 •
edited
Loading

Verification

  • Espressif-IDE 2.10.0 with this PR update site - No issues reported, able to update it.

  • Eclipse 2023-09 (4.29.0) with this PR update site- No issues reported, able to update it.

  • Espressif-IDE 2.9.1+ with this PR update site - Error while updating. I will check this further!

    Your original request has been modified.
    "Embedded C/C++ Templates Core Plug-in" is already installed, so an update will be performed instead.
    "Espressif IDF Plugins for Eclipse" is already installed, so an update will be performed instead.
    "Apache HttpClient" is already installed, so an update will be performed instead.
    "Embedded C/C++ CMSIS Packs Core Plug-in" is already installed, so an update will be performed instead.
    Cannot complete the install because one or more required items could not be found.
    Software being installed: Apache HttpClient 4.5.14.v20230516-1249 (org.apache.httpcomponents.httpclient 4.5.14.v20230516-1249)
    Missing requirement: Apache HttpClient 4.5.14.v20230516-1249 (org.apache.httpcomponents.httpclient 4.5.14.v20230516-1249) requires 'java.package; org.apache.http [4.4.16,4.5.0)' but it could not be found

@kolipakakondal kolipakakondal changed the title fix:Updatesite issue with the eclipse 2023-03 and lower fix:Updatesite issue with the Espressif-IDE 2.10.0 Sep 22, 2023
@AndriiFilippov
Copy link
Collaborator

@kolipakakondal hi!
Tested under:
OS - Windows 10 / Mac mini / Mac Ventura
ESP-IDF: v5.1.1

Using Espressif IDE v2.9.1 / v2.10 updated to version v2.11 using "Install New Software -> Archive->zip"
able to update. able to build project.
LGTM 👍

@kolipakakondal
Copy link
Collaborator Author

@kolipakakondal hi! Tested under: OS - Windows 10 / Mac mini / Mac Ventura ESP-IDF: v5.1.1

Using Espressif IDE v2.9.1 / v2.10 updated to version v2.11 using "Install New Software -> Archive->zip" able to update. able to build project. LGTM 👍

Thanks @AndriiFilippov for verifying. I was having an issue with the Espressif IDE v2.9.1 + pr update site archive

We can check this again on Monday and plan for v2.11.1 release accordingly.

@kolipakakondal kolipakakondal merged commit 3cc03dd into master Sep 26, 2023
7 checks passed
@kolipakakondal kolipakakondal deleted the updatesitefix branch September 26, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@AndriiFilippov AndriiFilippov Awaiting requested review from AndriiFilippov

@sigmaaa sigmaaa Awaiting requested review from sigmaaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kolipakakondal @AndriiFilippov